-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ac/package updates #2
Ac/package updates #2
Conversation
…w-to, moved public/internal under Reference
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
SiennaTemplate = "bed98974-b02a-5e2f-9ee0-a103f5c450dd" | ||
|
||
[compat] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a requirement for:
Documenter = "1"
docs/src/index.md
Outdated
|
||
------------ | ||
SIIP-PACKAGE has been developed as part of the Scalable Integrated Infrastructure Planning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple last changes. Remind me, are you able to compile the docs for this one?
.github/pull_request_template.md
Outdated
Check the [contributor guidelines](https://nrel-siip.github.io/SIIP-PACKAGE.jl/stable/code_base_developer_guide/developer/) | ||
Thanks for opening a PR to SIIP-PACKAGE.jl, please take note of the following when making a PR: | ||
|
||
Check the [contributor guidelines](https://nrel-siip.github.io/SIIP-PACKAGE.jl/stable/code_base_developer_guide/developer/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference will fail, since we don't have this page. Could you follow the format in PowerSystems to add a Reference > Developers > Developer Guildlines page? https://nrel-sienna.github.io/PowerSystems.jl/stable/api/developer_guidelines/
The Internals API can also go in the Developers subsection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url will need to be updated to point to the new Developer Guidelines page.
docs/src/quick_start_guide.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete this file? It's not being mapped in the make.jl anymore, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
@annacasavant and @kdayday the conflicts need to be fixed to merge this. |
964c372
into
NREL-Sienna:jd/merge_ac_changes
-Changed the name of package to SiennaTemplate.jl
-added Diataxis guidelines for documentation
-updated to Documenter 1.0
-updated formatter.jl
@kdayday
@jd-lara